Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ability to Use chevron and rightComponent prop on the InfoListItem at the same time #364

Closed
joebochill opened this issue Jan 17, 2022 · 0 comments · Fixed by #666
Closed
Assignees
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected drawer Affects Drawer Component info-list-item Affects Info List Item Component
Milestone

Comments

@joebochill
Copy link
Collaborator

joebochill commented Jan 17, 2022

Describe the bug

On the InfoListItem, if you specify rightComponent it will override the chevron and only show the right component.

What is the expected behavior?

User should be able to show the chevron and a custom rightComponent without having to manually combine them in the rightComponent prop.

What are the steps to reproduce?

  1. clone the repository
  2. yarn start:showcase
  3. Go to the list item example: http://localhost:3000/brightlayer-ui-components/data-display-components
  4. Configure an ILI to have chevron={true} and rightComponent={/*something*/}
  5. Observe that you only see the rightComponent

Anything else to add?

We have a pseudo workaround already in place within the DrawerNavItem. It is doing the work of combining the chevron and a rightComponent into one item for rightComponent. We should be able to base the approach around this, but in the ILI instead.

When fixing this, we will also need to do some refactoring in the Drawer components so that chevron and rightComponent are able to be passed down independently to the ILI.

@joebochill joebochill added bug Something not working as expected drawer Affects Drawer Component info-list-item Affects Info List Item Component needs-review Issues that we would like to revisit/review labels Jan 17, 2022
@joebochill joebochill added this to the 6.0.0 milestone Jan 17, 2022
@emclaug2 emclaug2 removed the needs-review Issues that we would like to revisit/review label Feb 2, 2022
@emclaug2 emclaug2 removed this from the 6.0.0 milestone Feb 17, 2022
@emclaug2 emclaug2 added this to the 6.0.1 milestone Apr 15, 2022
@joebochill joebochill added needs-review Issues that we would like to revisit/review hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 labels Sep 26, 2022
@joebochill joebochill changed the title Can't use rightComponent and chevron together Add Ability to Use chevron and rightComponent prop on the InfoListItem at the same time Sep 28, 2022
@joebochill joebochill added hacktoberfest Issues shared for contributions by the Hacktoberfest community and removed needs-review Issues that we would like to revisit/review labels Sep 30, 2022
@daileytj daileytj modified the milestones: 6.1.1, 6.2.0 Nov 7, 2022
@daileytj daileytj removed hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community labels Nov 7, 2022
@daileytj daileytj modified the milestones: 6.2.0, 6.3.0 Dec 1, 2022
@joebochill joebochill modified the milestones: 6.3.0, 6.2.0 Dec 1, 2022
@bkarambe bkarambe self-assigned this Dec 27, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected drawer Affects Drawer Component info-list-item Affects Info List Item Component
Development

Successfully merging a pull request may close this issue.

4 participants