Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ToolbarMenu component #351

Closed
joebochill opened this issue Dec 27, 2021 · 1 comment
Closed

Add a ToolbarMenu component #351

joebochill opened this issue Dec 27, 2021 · 1 comment
Assignees
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering dropdown-toolbar Affects Dropdown Toolbar Component enhancement Request for improvement or new feature
Milestone

Comments

@joebochill
Copy link
Collaborator

Describe the desired behavior

This will be a replacement for the existing DropdownToolbar component. We will build a generic component that will handle the dropdown arrow iconography and state and trigger the menu open and closed. The user will supply a ReactNode for the label (could be text, could be icon + text, etc.) and we will append the dropdown arrow beside their content. Clicking the content will open the menu described by the user (either through an items prop, or custom menu). Most of this functionality can simply be taken out of the existing dropdown toolbar.

Add deprecation warnings for the DropdownToolbar. Make sure that instructions for using the new approach is mentioned in the readme for the Appbar component (e.g., as an example).

Describe the current behavior

Rather than having this functionality built into a Toolbar, we will isolate it into a smaller sub-component that can be used in any toolbar (regular Mui Appbar, blui collapsible, etc.)

Is this request related to a current issue?

No

Additional Context

@joebochill joebochill added enhancement Request for improvement or new feature needs-review Issues that we would like to revisit/review dropdown-toolbar Affects Dropdown Toolbar Component labels Dec 27, 2021
@joebochill joebochill added this to the 5.4.0 milestone Dec 27, 2021
@ektasawant ektasawant self-assigned this Jan 18, 2022
@jeffvg jeffvg removed the needs-review Issues that we would like to revisit/review label Jan 19, 2022
@ektasawant
Copy link
Contributor

@emclaug2 emclaug2 closed this as completed Feb 4, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering dropdown-toolbar Affects Dropdown Toolbar Component enhancement Request for improvement or new feature
Development

No branches or pull requests

4 participants