Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons display hover styles when they are not being hovered on mobile #88

Open
daileytj opened this issue May 26, 2021 · 1 comment
Open
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected

Comments

@daileytj
Copy link
Contributor

daileytj commented May 26, 2021

Describe the bug

On mobile devices/simulators, buttons show hover state styles when they are not being hovered.

One instance is the "resend verification email" button on the verify email page in the create account workflow.

Another instance is the "continue" button on the account created success screen in the self-registration workflow.

There may be other buttons like this.

What is the expected behavior?

Buttons should not be showing hover state styles unless they are hovered.

What are the steps to reproduce?

Run these steps to get the example project running, and then view the details further down to create an error state for either the "Resend" or "Continue" button.

  1. Clone the repo (git clone https://github.com/brightlayer-ui/angular-workflows.git).
  2. CD into the project (cd angular-workflows)
  3. Run the example project (cd login-workflow && yarn start:example)
  4. Open Angular login workflow on a simulator or mobile device

"Resend Button"

  1. Click "Create Account" link on the login screen
  2. Continue through the workflow until you get to the verify email screen.
  3. Click the resend verification email.
  4. Observe hover styles on the button despite not actively hovering.

"Continue Button"

  1. Click the debug button on the login screen
  2. Click "Test Invite Register" link
  3. Continue through the workflow until you get to the account created screen.
  4. Observe hover styles on the button despite not actively hovering.

Screenshots or links to minimum reproduction example

Simulator Screen Shot - iPhone 12 - 2021-05-26 at 12 18 07

Simulator Screen Shot - iPhone 12 - 2021-05-26 at 12 20 06

@daileytj daileytj added bug Something not working as expected needs-review Issues that we would like to revisit/review labels May 26, 2021
@huayunh huayunh removed the needs-review Issues that we would like to revisit/review label Jun 9, 2021
@joebochill
Copy link
Collaborator

There is probably a particular mobile-specific style (e.g., active) getting applied here (that is, it's probably not actually the :hover styles). This might need to be ported to the themes repository if it's not specific to just the workflow.

@joebochill joebochill added this to the 2.4.1 milestone Dec 28, 2021
@emclaug2 emclaug2 modified the milestones: 3.1.0, 3.0.1 Apr 14, 2022
@emclaug2 emclaug2 removed this from the 3.0.2 milestone Nov 21, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected
Development

No branches or pull requests

4 participants