Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to remove BrowserModule imports from BluiAuthModule #278

Open
v-xiao opened this issue Jul 4, 2023 · 1 comment
Open

Need to remove BrowserModule imports from BluiAuthModule #278

v-xiao opened this issue Jul 4, 2023 · 1 comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected user-reported This was reported by a user outside the maintainers team.

Comments

@v-xiao
Copy link

v-xiao commented Jul 4, 2023

Describe the bug / expected behavior

At the component level we should not import BrowserModule, BrowserModule is only imported once in the root module, if BluiAuthModule is not used in AppModule, it will report an error

What are the steps to reproduce?

  1. Go to...
  2. Click on...

Screenshots / Screen recording

image
image

Code snippet / Link to minimum reproduction example

CODE HERE

Your environment information

Suggested fix

Anything else to add?
@v-xiao v-xiao added brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected needs-review Issues that we would like to revisit/review labels Jul 4, 2023
@JeffGreiner-eaton JeffGreiner-eaton added the user-reported This was reported by a user outside the maintainers team. label Jul 6, 2023
@surajeaton surajeaton removed the needs-review Issues that we would like to revisit/review label Jul 6, 2023
@surajeaton
Copy link
Contributor

@RaghavendranC-Eaton Will look at it and verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected user-reported This was reported by a user outside the maintainers team.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@v-xiao @JeffGreiner-eaton @surajeaton @RaghavendranC-Eaton