Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel value issue with zero value #556

Closed
julienvonoetinger-eaton opened this issue Dec 2, 2022 · 0 comments · Fixed by #592 or #593
Closed

Channel value issue with zero value #556

julienvonoetinger-eaton opened this issue Dec 2, 2022 · 0 comments · Fixed by #592 or #593
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected high-priority Issues that should be fixed sooner than later user-reported This was reported by a user outside the maintainers team.
Milestone

Comments

@julienvonoetinger-eaton
Copy link

julienvonoetinger-eaton commented Dec 2, 2022

Describe the bug

If you pass 0 as a value for the channel value component, it won't display the value.

What is the expected behavior?

The 0 value is visible.

What are the steps to reproduce?

Pass 0 as value to the component (see code snippet below).

Screenshots / Screen recording

channel-value

Code snippet / Link to minimum reproduction example

<blui-channel-value
  [value]="0"
  [units]="'kWh'"
>
</blui-channel-value>

Your environment information

"@brightlayer-ui/angular-components": "7.0.3",
"@brightlayer-ui/angular-themes": "7.0.1",
"@brightlayer-ui/chartjs": "^1.0.0",
"@brightlayer-ui/colors": "3.1.1",
"@brightlayer-ui/icons": "1.11.0",
"@brightlayer-ui/ng-progress-icons": "1.2.1",

Suggested fix

My assumption is that there is a if condition that check the value but 0 will return false therefore hiding the value.

Anything else to add?

@julienvonoetinger-eaton julienvonoetinger-eaton added bug Something not working as expected needs-review Issues that we would like to revisit/review labels Dec 2, 2022
@jeffvg jeffvg added user-reported This was reported by a user outside the maintainers team. high-priority Issues that should be fixed sooner than later and removed needs-review Issues that we would like to revisit/review labels Dec 8, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
@joebochill joebochill added this to the 8.0.1 milestone Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected high-priority Issues that should be fixed sooner than later user-reported This was reported by a user outside the maintainers team.
3 participants