Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drawer Footer should preserve its divider when the drawer collapses #484

Closed
huayunh opened this issue Aug 31, 2022 · 0 comments · Fixed by #595
Closed

Drawer Footer should preserve its divider when the drawer collapses #484

huayunh opened this issue Aug 31, 2022 · 0 comments · Fixed by #595
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected drawer Affects Drawer Component
Milestone
8.1.0

Comments

@huayunh
Copy link
Contributor

huayunh commented Aug 31, 2022 •
edited by emclaug2
Loading

Describe the bug

This is an issue affecting the <blui-drawer>. When the <blui-drawer> is collapsed, the divider in the <blui-drawer-footer> disappears.

What is the expected behavior?

When the drawer is collapsed, the divider (if enabled) should still be visible.

image

What are the steps to reproduce?

  1. Navigate to the Drawer Footer Playground.
  2. Double-check the hideContentOnCollapse and divider option is enabled.
  3. Close the Drawer.
  4. Observe that the divider is no longer visible

Additional Information

You can locally test out this component in our documentation playground:

  1. clone the repository
  2. yarn && yarn start
  3. navigate to http://localhost:4200/components/drawer/footer/playground
@huayunh huayunh added bug Something not working as expected needs-review Issues that we would like to revisit/review labels Aug 31, 2022
@huayunh huayunh added the drawer Affects Drawer Component label Sep 14, 2022
@ektasawant ektasawant removed the needs-review Issues that we would like to revisit/review label Sep 15, 2022
@joebochill joebochill added needs-review Issues that we would like to revisit/review hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community and removed needs-review Issues that we would like to revisit/review labels Sep 26, 2022
@emclaug2 emclaug2 removed hacktoberfest2022 Issues shared for contributions by the Hacktoberfest community in 2022 hacktoberfest Issues shared for contributions by the Hacktoberfest community labels Nov 16, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
@joebochill joebochill added this to the 8.0.1 milestone Feb 20, 2023
@raghavenc5 raghavenc5 mentioned this issue Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected drawer Affects Drawer Component
Milestone
8.1.0
4 participants
@emclaug2 @huayunh @ektasawant @joebochill