Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate parameters / configs #79

Open
gawela opened this issue Apr 3, 2020 · 5 comments
Open

Consolidate parameters / configs #79

gawela opened this issue Apr 3, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@gawela
Copy link
Contributor

gawela commented Apr 3, 2020

There are a lot of config files and launch file parameters flowing around. An effort for cleaning this up would be nice (nice-to-have!).

@gawela gawela added the enhancement New feature or request label Apr 3, 2020
@hermannsblum
Copy link
Collaborator

hermannsblum commented Apr 3, 2020

In particular, all config handling should be refactored at some point to use the ConfigProvider.

This makes it possible to use configs in libraries without explicitly relying on ROS. An example looks like this here:

// Set up configuration provider.
ConfigProvider::Ptr cfg =
    std::dynamic_pointer_cast<ConfigProvider>(std::make_shared<RosConfigProvider>(nh_private_));

// Create construction strategy
auto construction_strategy = std::make_shared<offset_surface::VertexNormalStrategy>(cfg);

@drehermarc
Copy link
Contributor

drehermarc commented Apr 3, 2020

Thanks for the remarks.
As soon as the pending PRs have been discussed, I will start a new PR in which I will try to generally clean the code in master correspondingly.

@hermannsblum
Copy link
Collaborator

I think this does not only apply to Marcs code btw, we should clean up some other modules as well.

@michaelpantic
Copy link
Member

@hermannsblum thought so too. I am currently cleaning up some of my code and will next week have a look on how we could modularize and consolidate the core a bit. I'll add a new general issue about this. Otherwise it'll grow out of our hands :)

@michaelpantic
Copy link
Member

#80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants