Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Remove usage of SaaSType enum #1261

Closed
galvana opened this issue Sep 6, 2022 · 1 comment · Fixed by ethyca/fides#1197
Closed

Remove usage of SaaSType enum #1261

galvana opened this issue Sep 6, 2022 · 1 comment · Fixed by ethyca/fides#1197
Assignees
Labels
enhancement New feature or request

Comments

@galvana
Copy link
Collaborator

galvana commented Sep 6, 2022

NOTE - this ticket has been re-created as ethyca/fides#1196 in fides repo, because it will be implemented in unified fides.

Is your feature request related to a specific problem?

SaaS connectors are in constant development and having tests that rely on a hard-coded list of connectors or connector counts causes issues during new development. We have to maintain awareness of which tests to update when a new connector is added but ideally this shouldn't be the case.

Describe the solution you'd like

  • Remove the SaaSType enum
  • Update any tests that assert a specific SaaS connector count to rely on the count of SaaS connectors from the SaaS connector registry
  • Update any tests that rely on specific connectors to be present to be independent of which connectors are available
    • For example: test_search_connection_types and test_get_connection_types in tests/ops/api/v1/endpoints/test_connection_template_endpoints.py
@galvana galvana added the enhancement New feature or request label Sep 6, 2022
@Kelsey-Ethyca
Copy link
Contributor

There are ui dependencies on this. We will need to find another way to handle this on the frontend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants