Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra delete icon from domains page buttons #5513

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Nov 19, 2024

Closes HJ-238

Description Of Changes

Removes an extra "Delete" icon from buttons on the "Domains" page that was accidentally left in during the button migration. Also narrows margin slightly.

Before:
Screenshot 2024-11-19 at 01 22 29

After:
Screenshot 2024-11-19 at 01 25 34

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 7:30am

Copy link

cypress bot commented Nov 19, 2024

fides    Run #11069

Run Properties:  status check passed Passed #11069  •  git commit 1eaa6a1654 ℹ️: Merge dc57bba2ffbba9ba1006c14ccfc3db1c0f09e46a into 2c64212e2cb6fdf30c0957cc6462...
Project fides
Branch Review refs/pull/5513/merge
Run status status check passed Passed #11069
Run duration 00m 37s
Commit git commit 1eaa6a1654 ℹ️: Merge dc57bba2ffbba9ba1006c14ccfc3db1c0f09e46a into 2c64212e2cb6fdf30c0957cc6462...
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jpople jpople merged commit 19b9a43 into main Nov 19, 2024
13 checks passed
@jpople jpople deleted the jpople/hj-238/remove-extra-delete-icon branch November 19, 2024 16:24
Copy link

cypress bot commented Nov 19, 2024

fides    Run #11079

Run Properties:  status check passed Passed #11079  •  git commit 19b9a430b2: Remove extra delete icon from domains page buttons (#5513)
Project fides
Branch Review main
Run status status check passed Passed #11079
Run duration 00m 36s
Commit git commit 19b9a430b2: Remove extra delete icon from domains page buttons (#5513)
Committer jpople
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants