Migrate vendor selector to Ant #5459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* visit Manage your vendors page http://localhost:3000/consent/configure * Click "Add Vendors" button * Click "Add custom vendor" button * Ensure vendor picker select works as expected, including: selecting from the list, using the tab key to complete the autosuggestion, adding a new value by pressing the tab key (or click away), adding a new value by clicking that option from the menu.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5459/merge
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
jpople
reviewed
Nov 5, 2024
| if (newValue) { | ||
| const newVendorId = options.some((opt) => opt.value === newValue.value) | ||
| ? newValue.value | ||
| : undefined; | ||
| setFieldValue("vendor_id", newVendorId); | ||
| await setValue( |
There was a problem hiding this comment.
Didn't know you could explicitly await a state call, this is a much nicer solution to that error message bug.
jpople
reviewed
Nov 5, 2024
@jpople updated! Thanks for catching that. |
jpople
approved these changes
Nov 5, 2024
fides
|
||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 36s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-142
Description Of Changes
Vendor selector is a bit complex, so we're migrating it separately from the other Select components first.
Code Changes
AutosuggestSuffixas reusable typeahead helperVendorSelectorcomponent to use Ant's Select componentSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md