Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HJ-139 - Fix Pytest-Ctl-External tests #5457

Merged
merged 15 commits into from
Nov 6, 2024
Merged

Conversation

andres-torres-marroquin
Copy link
Contributor

@andres-torres-marroquin andres-torres-marroquin commented Nov 4, 2024

Closes #HJ-139

Description Of Changes

Fix Pytest-Ctl-External tests

Code Changes

  • Updated some passwords to pull them from 1Password intead of GH Secrets. .github/workflows/backend_checks.yml
  • Updated noxfiles/setup_tests_nox.py to make it simpler.

Steps to Confirm

  • Look at the checks on the CI.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 6, 2024 6:50pm

@andres-torres-marroquin andres-torres-marroquin added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Nov 4, 2024
Copy link

cypress bot commented Nov 5, 2024

fides    Run #10850

Run Properties:  status check passed Passed #10850  •  git commit d9f280851e ℹ️: Merge c478d8a1491da8e3864c14e8c4ff30d2ff6cba68 into 722444864fa420685ce901fc6e90...
Project fides
Branch Review refs/pull/5457/merge
Run status status check passed Passed #10850
Run duration 00m 39s
Commit git commit d9f280851e ℹ️: Merge c478d8a1491da8e3864c14e8c4ff30d2ff6cba68 into 722444864fa420685ce901fc6e90...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.42%. Comparing base (5389ae0) to head (b542336).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5457   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         385      385           
  Lines       24152    24152           
  Branches     2630     2630           
=======================================
+ Hits        20631    20633    +2     
+ Misses       2967     2966    -1     
+ Partials      554      553    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andres-torres-marroquin andres-torres-marroquin changed the title HJ-139 - Fixing tests HJ-139 - Fix tests on fides - Pytest-Ctl-External Nov 6, 2024
@andres-torres-marroquin andres-torres-marroquin marked this pull request as ready for review November 6, 2024 15:30
@andres-torres-marroquin andres-torres-marroquin changed the title HJ-139 - Fix tests on fides - Pytest-Ctl-External HJ-139 - Fix Pytest-Ctl-External tests Nov 6, 2024
@andres-torres-marroquin andres-torres-marroquin requested a review from a team as a code owner November 6, 2024 15:53
env:
OP_SERVICE_ACCOUNT_TOKEN: ${{ secrets.OP_SERVICE_ACCOUNT_TOKEN }}

# Secrets to pull from 1Password
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gonna be great for centralizing the privacy information!

@andres-torres-marroquin andres-torres-marroquin merged commit 04461d0 into main Nov 6, 2024
14 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-139 branch November 6, 2024 18:50
Copy link

cypress bot commented Nov 6, 2024

fides    Run #10852

Run Properties:  status check passed Passed #10852  •  git commit 04461d0687: HJ-139 - Fix Pytest-Ctl-External tests (#5457)
Project fides
Branch Review main
Run status status check passed Passed #10852
Run duration 00m 37s
Commit git commit 04461d0687: HJ-139 - Fix Pytest-Ctl-External tests (#5457)
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants