Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: Add "Download request data" for completed access requests #5407

Merged
merged 10 commits into from
Oct 23, 2024
Merged

FE: Add "Download request data" for completed access requests #5407

merged 10 commits into from
Oct 23, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Oct 23, 2024

Closes HJ-18

Description Of Changes

Adds UI for downloading request data on completed access requests.

Screenshot 2024-10-23 at 00 53 10

Code Changes

  • Update OpenAPI types
  • Adds new component to download request data behind a new beta flag
  • Tiny refactor to request details page

Steps to Confirm

  • Enable the new "Download access request results" beta flag
  • With your request storage configured to "local", make an access request and an erasure request from the privacy center
  • View request details on both in Admin UI
  • Access request should show "Download request results" button that's disabled
  • Erasure request shouldn't show button
  • Now configure S3 storage (credentials are in 1Password)
  • Again make an access request and an erasure request from the privacy center
  • View request details on both in Admin UI
  • Access request should show "Download request results" button
  • Clicking on button should download a JSON file (will be empty)
  • Erasure request still shouldn't show button

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 4:08pm

@cypress Cypress
Copy link

cypress bot commented Oct 23, 2024 •
edited
Loading

fides    Run #10573

Run Properties:  status check passed Passed #10573  •  git commit 1f3bf2c017 ℹ️: Merge c040cc73d4744543a7600a250421f2ac62b99fc7 into 48a749864ea501d2010560941f0d...
Project fides
Branch Review refs/pull/5407/merge
Run status status check passed Passed #10573
Run duration 00m 39s
Commit git commit 1f3bf2c017 ℹ️: Merge c040cc73d4744543a7600a250421f2ac62b99fc7 into 48a749864ea501d2010560941f0d...
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

gilluminate
gilluminate approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Tested locally and it worked as expected.

@jpople jpople merged commit 8d478b2 into main Oct 23, 2024
13 checks passed
@jpople jpople deleted the jpople/hj-18/privacy-request-data branch October 23, 2024 17:50
@cypress Cypress
Copy link

cypress bot commented Oct 23, 2024

fides    Run #10587

Run Properties:  status check passed Passed #10587  •  git commit 8d478b2470: FE: Add "Download request data" for completed access requests (#5407)
Project fides
Branch Review main
Run status status check passed Passed #10587
Run duration 00m 41s
Commit git commit 8d478b2470: FE: Add "Download request data" for completed access requests (#5407)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @gilluminate