Apply any updated state to the overlay #5384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 40s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
gilluminate
force-pushed
the
HJ-22-incorrect-gpc-signal-on-manual
branch
from
a86b4be
to
c52a4c3
Compare
gilluminate
force-pushed
the
HJ-22-incorrect-gpc-signal-on-manual
branch
from
c52a4c3
to
ed40fda
Compare
eastandwestwind
requested changes
Oct 16, 2024
CHANGELOG.md
Outdated
| @@ -20,6 +20,7 @@ The types of changes are: | |||
| ### Fixed | |||
| - Fixed a bug where D&D tables were rendering stale data [#5372](https://github.com/ethyca/fides/pull/5372) | |||
| - Fixed issue where Dataset with nested fields was unable to edit Categories [#5383](https://github.com/ethyca/fides/pull/5383) | |||
| - Fixed racecondition where GPP being updated after FidesJS initialization caused Privacy Notices to be in the wrong state [#5384](https://github.com/ethyca/fides/pull/5384) | |||
There was a problem hiding this comment.
I think you mean GPC here?
| @@ -124,6 +125,11 @@ const NoticeOverlay: FunctionComponent<OverlayProps> = ({ | |||
| Array<string> | |||
| >(initialEnabledNoticeKeys()); | |||
|
|
|||
| window.addEventListener("FidesUpdating", (event) => { | |||
| // If GPP is being applied after initialization, we need to update the initial overlay to reflect the new state. This is especially important for Firefox browsers (Gecko) because GPP gets applied rather late due to how it handles queuing the `setTimeout` on the last step of our `initialize` function. | |||
eastandwestwind
approved these changes
Oct 16, 2024
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-22
Description Of Changes
If GPC (browser's "Do Not Track") is being applied after Fides initialization, we need to update the initial overlay to reflect the new state.
This is especially important for Firefox browsers (Gecko) because—not only does FF make it easy to enable GPC—GPC gets applied rather late due to how Gecko handles queuing the
setTimeouton the last step of ourinitializefunction.Code Changes
FidesUpdatingand use that to update the Overlay's notices as applicableSteps to Confirm
Pre-Merge Checklist
CHANGELOG.md