Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Firefox overflow issue on Data Categories column #5369

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Address Firefox overflow issue on Data Categories column #5369

merged 2 commits into from
Oct 12, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Oct 11, 2024 •
edited
Loading

Closes HJ-37

Code Changes

  • change overflowX to overflow for Firefox support
  • pass along the "hidden" value to the overflow attribute

Steps to Confirm

CleanShot 2024-10-11 at 15 48 54@2x

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 11, 2024 10:51pm

@cypress Cypress
Copy link

cypress bot commented Oct 11, 2024 •
edited
Loading

fides    Run #10389

Run Properties:  status check passed Passed #10389  •  git commit f8483b35dc ℹ️: Merge c0d059ebdce6b6a1d6e51ef5ca1315898ae24432 into 240f5401620276c061ee5a94d819...
Project fides
Run status status check passed Passed #10389
Run duration 00m 41s
Commit git commit f8483b35dc ℹ️: Merge c0d059ebdce6b6a1d6e51ef5ca1315898ae24432 into 240f5401620276c061ee5a94d819...
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

lucanovera
lucanovera approved these changes Oct 12, 2024
View reviewed changes
Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! I replicated the bug and confirmed the fix on firefox.

before
Screen Shot 2024-10-11 at 17 34 44

after fix
Screen Shot 2024-10-11 at 17 35 22

Approved!

@gilluminate gilluminate merged commit 08e9a08 into main Oct 12, 2024
13 checks passed
@gilluminate gilluminate deleted the HJ-37-visual-bug-on-data-category branch October 12, 2024 19:28
gilluminate added a commit that referenced this pull request Oct 12, 2024
@gilluminate
Address Firefox overflow issue on Data Categories column (#5369)
f32fdec
@cypress Cypress
Copy link

cypress bot commented Oct 12, 2024

fides    Run #10390

Run Properties:  status check passed Passed #10390  •  git commit 08e9a08735: Address Firefox overflow issue on Data Categories column (#5369)
Project fides
Run status status check passed Passed #10390
Run duration 00m 38s
Commit git commit 08e9a08735: Address Firefox overflow issue on Data Categories column (#5369)
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucanovera lucanovera lucanovera approved these changes

@jpople jpople Awaiting requested review from jpople

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @lucanovera