Custom report models #5344
Custom report models #5344
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| yield custom_report | ||
| custom_report.delete(db) | ||
|
|
||
| def test_create_custom_report(self, db: Session, user: FidesUser): |
There was a problem hiding this comment.
this test doesn't have any assertions -- is that expected?
There was a problem hiding this comment.
I was just asserting that we could create it with no errors but I added field assertions now
| sa.Column("name", sa.String(), nullable=True), | ||
| sa.Column("type", sa.String(), nullable=False), | ||
| sa.Column("created_by", sa.String(), nullable=True), | ||
| sa.Column("config", postgresql.JSONB(astext_type=sa.Text()), nullable=True), |
There was a problem hiding this comment.
Are we storing the table_state and column_map within the config (as opposed to using two separate columns) because we expect that we'll need more things in the config if/when we implement custom reports in other parts of the UI?
There was a problem hiding this comment.
That's right, especially for table_state, Jason is still trying to figure out the schema for the front-end. It's tricky because the metadata to capture a Tanstack table is different from an ANT table so I just provided a flexible solution for now.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5344 +/- ##
==========================================
- Coverage 85.44% 85.33% -0.12%
==========================================
Files 378 380 +2
Lines 23896 24021 +125
Branches 3189 3219 +30
==========================================
+ Hits 20419 20499 +80
- Misses 2892 2932 +40
- Partials 585 590 +5 ☔ View full report in Codecov by Sentry. |
fides
|
||||||||||||||||||||||||||
| Project |
fides
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Adrian Galvan |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
Closes PROD-2673
Description Of Changes
Introduces the
CustomReportmodel with the following properties:A custom report, for now, is defined as an object containing the table state (to be determined by the front-end) and a mapping of column keys to custom labels.
Code Changes
CustomReportmodelSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works