-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-2821-Consent-automation-accordion #5330
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
galvana
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy!
fides Run #10161
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5330/merge
|
Run status |
Passed #10161
|
Run duration | 00m 41s |
Commit |
24ca7b360f ℹ️: Merge daf3af02eda69c0472a2ac5294256eaeb37501c5 into 077d26642df0359b60d351f8f252...
|
Committer | Lucano Vera |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
fides Run #10162
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10162
|
Run duration | 00m 40s |
Commit |
c0c6d73e59: PROD-2821-Consent-automation-accordion (#5330)
|
Committer | Lucano Vera |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fix bug where Consent Automation Accordion shows up on integrations without support for consent automation.
Code Changes
Steps to Confirm
Go to systems, select a system that has an integration that is not Iterable
Go to integrations tab and check that the Consent automation accordion is not visible
Go to systems, select a system that has an Iterable integration or create a system with an Iterable integration
Go to integrations tab and check that the Consent automation accordion is visible
Screenshots
Iterable Integration
HubSpot Integration
Pre-Merge Checklist
CHANGELOG.md