Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2821-Consent-automation-accordion #5330

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Sep 25, 2024

Description Of Changes

Fix bug where Consent Automation Accordion shows up on integrations without support for consent automation.

Code Changes

  • Check for when consentableItems array is empty

Steps to Confirm

  • Go to systems, select a system that has an integration that is not Iterable

  • Go to integrations tab and check that the Consent automation accordion is not visible

  • Go to systems, select a system that has an Iterable integration or create a system with an Iterable integration

  • Go to integrations tab and check that the Consent automation accordion is visible

Screenshots

Iterable Integration
Screen Shot 2024-09-25 at 14 47 37

HubSpot Integration
Screen Shot 2024-09-25 at 14 47 45

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2024 6:01pm

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy!

Copy link

cypress bot commented Sep 25, 2024

fides    Run #10161

Run Properties:  status check passed Passed #10161  •  git commit 24ca7b360f ℹ️: Merge daf3af02eda69c0472a2ac5294256eaeb37501c5 into 077d26642df0359b60d351f8f252...
Project fides
Branch Review refs/pull/5330/merge
Run status status check passed Passed #10161
Run duration 00m 41s
Commit git commit 24ca7b360f ℹ️: Merge daf3af02eda69c0472a2ac5294256eaeb37501c5 into 077d26642df0359b60d351f8f252...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@lucanovera lucanovera merged commit c0c6d73 into main Sep 25, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2821-Consent-automation-accordion branch September 25, 2024 18:18
Copy link

cypress bot commented Sep 25, 2024

fides    Run #10162

Run Properties:  status check passed Passed #10162  •  git commit c0c6d73e59: PROD-2821-Consent-automation-accordion (#5330)
Project fides
Branch Review main
Run status status check passed Passed #10162
Run duration 00m 40s
Commit git commit c0c6d73e59: PROD-2821-Consent-automation-accordion (#5330)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants