-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-2796: ignore 400 errors on Talkable's person endpoint #5317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
galvana
approved these changes
Sep 23, 2024
fides Run #10058
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5317/merge
|
Run status |
Passed #10058
|
Run duration | 00m 40s |
Commit |
ef8a9ae620 ℹ️: Merge 7c64b8d7f0f159b4367e565727063375731a82d9 into b4e014f2001d57284659a686651e...
|
Committer | Robert Keyser |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
RobertKeyser
changed the title
fix: ignore 400 errors on Talkable's person endpoint
PROD-2796: ignore 400 errors on Talkable's person endpoint
Sep 23, 2024
fides Run #10061
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10061
|
Run duration | 00m 42s |
Commit |
d5986a5c39: PROD-2796: ignore 400 errors on Talkable's person endpoint (#5317)
|
Committer | Robert Keyser |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2796
Description Of Changes
Ignores
400
errors thrown by Talkable when a person is not found.Ideally we'd only ignore the
400
s when the error message matches that case, but for now, we'll ignore all400
errors. We can implement that when #5211 is merged.Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
main
downgrade()
migration is correct and works