add timing to debug logs for fides.js #5245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5245/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
| window.addEventListener("FidesUIShown", () => { | ||
| // Log event timing | ||
| const fidesLoaded = performance | ||
| .getEntriesByType("resource") |
There was a problem hiding this comment.
Can performance.getEntriesByType("resource") ever be null?
There was a problem hiding this comment.
not null, only empty array []
| fidesTiming[ | ||
| `fides.js (${(fidesLoaded.encodedBodySize / 1000).toFixed(2)} kB)` | ||
| ] = { | ||
| "Time (ms)": parseFloat(fidesLoaded.responseEnd.toFixed(2)), |
There was a problem hiding this comment.
Can fidesLoaded be null?
There was a problem hiding this comment.
only if fides.js didn't load on the demo page, and then we have bigger fish to fry 😄
| .getEntriesByType("resource") | ||
| .find((entry) => entry.name.includes("fides")); | ||
| const fidesEvents = performance | ||
| .getEntriesByType("mark") |
There was a problem hiding this comment.
same here- can we rely on this existing?
There was a problem hiding this comment.
worst case it's empty array []
eastandwestwind
approved these changes
Aug 30, 2024
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Jason Gill |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adds timings to our debug logs for fides.js
Steps to Confirm
http://localhost:3001/fides-js-demo.html?geolocation=eea)Pre-Merge Checklist
CHANGELOG.md