Update D&D action button loading behavior #5201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
gilluminate
approved these changes
Aug 16, 2024
| <Text marginLeft={icon && 1} fontWeight="semibold" fontSize={12}> | ||
| {title} | ||
| </Text> | ||
| {title} | ||
| </Button> | ||
| ); |
There was a problem hiding this comment.
Since you are extending all ButtonProps in the interface now, you should be able to simplify this quite a bit just by passing all of those props along to the Button. A good best-practice for making custom components a true extension of the original.
const ActionButton = ({
title,
icon,
variant = "outline",
...props
}: ActionButtonProps) => (
<Button
size="xs"
variant={variant}
data-testid={`action-${title}`}
loadingText={title}
leftIcon={icon}
{...props}
>
{title}
</Button>
);
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2547
Description Of Changes
Updates loading behavior on D&D action buttons; spinner now renders inside of button corresponding to action that's loading. Also adds loading state to discovery monitor table "Scan" action button.
Previous behavior:
Screen.Recording.2024-08-15.at.09.20.16.mov
New behavior:
Screen.Recording.2024-08-15.at.09.20.48.mov
Code Changes
Pre-Merge Checklist
CHANGELOG.md