Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing OAuth2 config for Snap integration #5158

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Aug 6, 2024

Closes #PROD-2542

Description Of Changes

Fixes some issues with the OAuth2 config

Code Changes

  • Updated snap_config.yml

Steps to Confirm

  • Configure the Snap integration and verify that the connection can be authorized.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 6, 2024 4:21pm

@galvana galvana requested a review from Vagoasdf August 6, 2024 01:28
@galvana galvana marked this pull request as ready for review August 6, 2024 01:28
@galvana galvana requested a review from a team as a code owner August 6, 2024 01:28
Copy link

cypress bot commented Aug 6, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 437b7904d7 ℹ️
Started Aug 6, 2024 4:33 PM
Ended Aug 6, 2024 4:34 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.49%. Comparing base (b29cbf5) to head (36d2f15).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5158   +/-   ##
=======================================
  Coverage   86.49%   86.49%           
=======================================
  Files         359      359           
  Lines       22484    22484           
  Branches     2979     2979           
=======================================
  Hits        19448    19448           
  Misses       2503     2503           
  Partials      533      533           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Vagoasdf Vagoasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, but since we paired working on these, we might want another par of eyes reviewing this PR

@galvana galvana merged commit baa3ea1 into main Aug 6, 2024
18 checks passed
@galvana galvana deleted the PROD-2542-update-snap-integration-auth branch August 6, 2024 16:26
Copy link

cypress bot commented Aug 6, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit baa3ea1
Started Aug 6, 2024 4:38 PM
Ended Aug 6, 2024 4:38 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants