Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fixes on monitor configuration UI #5142

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 31, 2024

Closes #

Description Of Changes

Text fixes:

  • Change heading of "Location" column in monitor table to "Scope"
  • Change title of "Projects" table in project selection table to "Scope"
  • Rephrase project selection tooltip slightly

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 2:43pm

Copy link

cypress bot commented Jul 31, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 281bcf33e9 ℹ️
Started Jul 31, 2024 2:55 PM
Ended Jul 31, 2024 2:55 PM
Duration 00:34 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@lucanovera lucanovera self-requested a review July 31, 2024 13:49
Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text changes look good. Approved.

@jpople jpople merged commit 7e88b0f into main Jul 31, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2466/location-text-fix branch July 31, 2024 14:59
Copy link

cypress bot commented Jul 31, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 7e88b0f
Started Jul 31, 2024 3:11 PM
Ended Jul 31, 2024 3:12 PM
Duration 00:35 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants