Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status field to D&D tables #5141

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 31, 2024

Closes PROD-2325, PROD-2331

Description Of Changes

  • Adds "status" column to D&D tables, replacing previous "change type" columns
  • Adds icon for monitored or muted resources with no change when in full schema view:

Screenshot 2024-07-30 at 20 51 31

  • Also adds tooltip legend for icons to all tables:

Screenshot 2024-07-30 at 20 57 18

Code Changes

  • Add new legend and badge status cell components
  • Refactor icon display
  • Add new icon types
  • Remove DiscoveryMonitorStatusEnum that wasn't being used anywhere

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 3:06pm

@@ -8,6 +8,7 @@ export const TableActionBar = ({ children, ...props }: StackProps) => (
borderWidth="1px"
borderBottomWidth="0px"
borderColor="gray.200"
zIndex={11}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The THead on FidesTable has a z-index of 10, so this needed to be higher in order for the popover to render correctly.

Copy link

cypress bot commented Jul 31, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit d06686cc3c ℹ️
Started Jul 31, 2024 3:13 PM
Ended Jul 31, 2024 3:13 PM
Duration 00:35 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@lucanovera lucanovera self-requested a review July 31, 2024 13:51
Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Love these UI changes. The code looks good and found no problems with the ui testing. approved!

@jpople jpople merged commit 135b030 into main Jul 31, 2024
13 checks passed
@jpople jpople deleted the jpople/prod-2331/dnd-table-status-field branch July 31, 2024 15:14
Copy link

cypress bot commented Jul 31, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 135b030
Started Jul 31, 2024 3:27 PM
Ended Jul 31, 2024 3:27 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants