Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2336 Add notice when messaging is in global or basic mode #5090

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jul 17, 2024

Description Of Changes

Add notice in messaging page when property specific messaging isn't enabled.

Code Changes

  • Added InfoBox with message when the messaging config variable isn't true

Steps to Confirm

  • Edit the .env file for fidesplus with FIDES__NOTIFICATIONS__ENABLE_PROPERTY_SPECIFIC_MESSAGING = false
  • Login to admin-ui and go to Messaging page
  • Check that it displays the appropriate notice about being in global mode
  • Edit the .env file for fidesplus with FIDES__NOTIFICATIONS__ENABLE_PROPERTY_SPECIFIC_MESSAGING = true
  • Check that it doesn't display the global mode notice

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 1:26pm

Copy link

cypress bot commented Jul 17, 2024

Passing run #8957 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 74012f0 into d0d3703...
Project: fides Commit: 0f4b759ef4 ℹ️
Status: Passed Duration: 00:34 💡
Started: Jul 17, 2024 1:34 PM Ended: Jul 17, 2024 1:35 PM

Review all test suite changes for PR #5090 ↗︎

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-17 at 4 21 54 PM

This looks good, just making sure @mfbrown has taken a look at the copy?

@lucanovera
Copy link
Contributor Author

Screenshot 2024-07-17 at 4 21 54 PM This looks good, just making sure @mfbrown has taken a look at the copy?

Yes, we decided to change the copy a bit. It documented in the ticket's comments. Thanks for the CR.

@lucanovera lucanovera merged commit 9f87c2e into main Jul 17, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2336-Add-notice-about-messaging-not-being-enabled-until-the-env-variable-is-set branch July 17, 2024 14:26
Copy link

cypress bot commented Jul 17, 2024

Passing run #8961 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

PROD-2336 Add notice when messaging is in global or basic mode (#5090)
Project: fides Commit: 9f87c2ec24
Status: Passed Duration: 00:38 💡
Started: Jul 17, 2024 2:38 PM Ended: Jul 17, 2024 2:39 PM

Review all test suite changes for PR #5090 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants