Fix system information form getting stuck on loading spinner

[jpople]

Closes PROD-2251

Description Of Changes

Fixes a bug where, on trying to view a system's detail page, a user with the Viewer role would get caught in an infinite "loading" screen while the dictionary query 403'd repeatedly.

This bug came from the way the dictionary query was being called; RTK Query re-runs the query and re-renders the page automatically when it errors, but the error result wasn't being cached so the query got stuck in a loop. The fix was just adding a check to show the page anyway if the query returns an error.

Code Changes

• Allow system information form to load even when dictionary query errors
• Replaced top-left green spinner with centered FidesSpinner
• Added test to confirm that page loads correctly

Steps to Confirm

• Create two systems
• Create a user with the Viewer role and assign one of the systems to the user
• Sign in as the user
• View the detail page for the system that was assigned to the user
• Page should render; should be able to make and submit changes
• View the detail page for the system not assigned to the user
• Page should render; if the user tries to make changes, should get a "not authorized" error

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Issue Requirements are Met
• Update CHANGELOG.md

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 27, 2024 8:15pm

[cypress]

Passing run #8588 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge b9256f0 into 0e34550...
Project: fides	Commit: 505f8ae8ef ℹ️
Status: Passed	Duration: 00:36 💡
Started: Jun 27, 2024 8:23 PM	Ended: Jun 27, 2024 8:24 PM

Review all test suite changes for PR #5034 ↗︎

[cypress]

Passing run #8593 ↗︎

0	4	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Fix system information form getting stuck on loading spinner (#5034)
Project: fides	Commit: dec991016e
Status: Passed	Duration: 00:35 💡
Started: Jun 27, 2024 9:28 PM	Ended: Jun 27, 2024 9:29 PM

Review all test suite changes for PR #5034 ↗︎