fix add icon being accidentally tiny #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| export * from "./CustomFieldsList"; | ||
| export * from "./CustomFieldsModal"; |
There was a problem hiding this comment.
Were these just dangling unused components?
There was a problem hiding this comment.
Yep, they were exported here but neither was imported anywhere. ¯\_(ツ)_/¯
Passing run #8247 ↗︎
Details:
Review all test suite changes for PR #4975 ↗︎ |
||||||||||||||||||||
|
@eastandwestwind CreateCustomLists and CustomFieldForm are not using the tiny incorrect AddIcon but rather a locally defined icon also called AddIcon that is a reasonable size. It's in ~/features/common/custom-fields/icons/AddIcon.tsx, you can see it on the "add a list value" button here:
|
eastandwestwind
approved these changes
Jun 11, 2024
Passing run #8249 ↗︎
Details:
Review all test suite changes for PR #4975 ↗︎ |
||||||||||||||||||||
jpople
added a commit
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Fixes add icon on some buttons mistakenly being wrong size.
Changes icon on:
ScrollableList component used in privacy experience/notice forms:
Before:
After:
Data uses tab in system information form (both empty state and when data uses are present):
Before:
After:
Code Changes
Pre-Merge Checklist
CHANGELOG.md