Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move data map reporting table out of beta #4963

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jun 7, 2024

Closes PROD-2171

Description Of Changes

Removes the feature flag on the data map Reporting page so that it permanently appears in the left nav. Also removes functionality from the Data Lineage page map view that now resides on the data map Reporting table.

Code Changes

  • Remove feature flag and references to it
  • Remove data map table from Data Lineage page
  • Remove toggle buttons for switching between map and table
  • Remove table settings button and modal
  • Remove data export button and modal, and remove npm packages that were only supporting this old export method

Steps to Confirm

  • Visit Data Lineage page in Fides Admin UI
  • Verify that Toggles, Column Settings, and Download options have all been removed
  • Verify that all users can see the Reporting link in the left nave and can visit that page (feature flag has been removed)

Pre-Merge Checklist

Copy link

vercel bot commented Jun 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 6:52pm

Copy link

cypress bot commented Jun 7, 2024

Passing run #8192 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4979871 into c43d02f...
Project: fides Commit: 3efa66fc91 ℹ️
Status: Passed Duration: 00:33 💡
Started: Jun 7, 2024 7:01 PM Ended: Jun 7, 2024 7:02 PM

Review all test suite changes for PR #4963 ↗︎

@gilluminate gilluminate merged commit 2853d11 into main Jun 7, 2024
13 checks passed
@gilluminate gilluminate deleted the gill/PROD-2171_move-data-map-reporting-table branch June 7, 2024 21:36
Copy link

cypress bot commented Jun 7, 2024

Passing run #8196 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Move data map reporting table out of beta (#4963)
Project: fides Commit: 2853d11aff
Status: Passed Duration: 00:37 💡
Started: Jun 7, 2024 9:47 PM Ended: Jun 7, 2024 9:47 PM

Review all test suite changes for PR #4963 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants