-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-1983 Privacy Center custom paths for properties #4907
PROD-1983 Privacy Center custom paths for properties #4907
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…loaded. Display 404 page if a custom path was used, but didn't match any property.
08a204d
to
b68e21a
Compare
clients/privacy-center/components/modals/consent-request-modal/ConsentRequestModal.tsx
Dismissed
Show resolved
Hide resolved
…Privacy-Center-to-lookup-config-and-style-by-property
Passing run #7932 ↗︎
Details:
Review all test suite changes for PR #4907 ↗︎ |
…Privacy-Center-to-lookup-config-and-style-by-property
…Privacy-Center-to-lookup-config-and-style-by-property
…Privacy-Center-to-lookup-config-and-style-by-property
…Privacy-Center-to-lookup-config-and-style-by-property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall, just one update requested to reduce complexity
if (process.env.NODE_ENV === "development") { | ||
// eslint-disable-next-line no-console | ||
console.log("Loading Privacy Center property into Redux store..."); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth creating a debugLog
util for privacy center like fides-js has. Not necessary before merge, just a suggestion for future reference.
…Privacy-Center-to-lookup-config-and-style-by-property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating! Looks good.
Co-authored-by: Lucano Vera <[email protected]>
Description Of Changes
Update the privacy center to accept the new custom paths for properties. ie. myprivacycenter.com/mynewproperty. If a custom path was used, it will call the new "get property by path" plus endpoint and display the privacy center. It will also load the privacy center config & stylesheet from that specific property.
Code Changes
Steps to reproduce
Screenshots
Regular home path loads config and css as usual
New custom path loads config and css from the property itself. In this case I change it so that the texts say the word purple and the custom stylesheet overrides the body text color's to be purple as well.
Pre-Merge Checklist
CHANGELOG.md