Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sourcemaps from fides-js dist #4887

Merged
merged 2 commits into from
May 13, 2024
Merged

Remove sourcemaps from fides-js dist #4887

merged 2 commits into from
May 13, 2024

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented May 13, 2024 •
edited
Loading

Closes PROD-2080

Description Of Changes

Only include sourcemaps when in dev mode

Code Changes

  • restore previous change where IS_DEV was commented out and true was left in

Steps to Confirm

  • build and run Privacy Center
  • View source of fides.js in browser devTools
  • Note the browser warning that the sourcemap can’t be found is now gone

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 13, 2024 8:43pm

@gilluminate gilluminate requested a review from NevilleS May 13, 2024 20:43
NevilleS
NevilleS approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(this was me wasn't it)

@gilluminate gilluminate marked this pull request as ready for review May 13, 2024 20:47
@cypress Cypress
Copy link

cypress bot commented May 13, 2024 •
edited
Loading

Passing run #7707 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 757154d into 40c3b8d...
Project: fides Commit: 939c877273 ℹ️
Status: Passed Duration: 00:35 💡
Started: May 13, 2024 8:54 PM Ended: May 13, 2024 8:55 PM

Review all test suite changes for PR #4887 ↗︎

@gilluminate gilluminate merged commit 1a9d642 into main May 13, 2024
13 checks passed
@gilluminate gilluminate deleted the PROD-2080-remove-sourcemaps-from branch May 13, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NevilleS NevilleS NevilleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @NevilleS