Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fides_ints_116_twilio_review #4872

Merged
merged 12 commits into from
May 10, 2024
Merged

fides_ints_116_twilio_review #4872

merged 12 commits into from
May 10, 2024

Conversation

MarcGEthyca
Copy link
Contributor

@MarcGEthyca MarcGEthyca commented May 8, 2024

Closes #INTS 116

Description Of Changes

_Changes to the dataset _

Code Changes

  • Added a few more classifications to the dataset for Twilio

Steps to Confirm

  • verify changes to dataset have been made

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    existing documentation does not need changes
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview May 10, 2024 6:19pm

Copy link

cypress bot commented May 8, 2024

Passing run #7686 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 388c3d4 into 1e9d485...
Project: fides Commit: c90dca727e ℹ️
Status: Passed Duration: 00:37 💡
Started: May 10, 2024 6:30 PM Ended: May 10, 2024 6:31 PM

Review all test suite changes for PR #4872 ↗︎

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (477ebe8) to head (271bb63).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4872   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files         346      346           
  Lines       20879    20879           
  Branches     2734     2734           
=======================================
  Hits        18114    18114           
  Misses       2289     2289           
  Partials      476      476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcGEthyca MarcGEthyca requested a review from galvana May 8, 2024 14:05
@MarcGEthyca MarcGEthyca marked this pull request as ready for review May 8, 2024 14:31
@MarcGEthyca MarcGEthyca requested a review from a team as a code owner May 8, 2024 14:31
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, make sure to bump the version to 0.0.5 so that existing instances of Twilio get the updated dataset on upgrade.

@MarcGEthyca MarcGEthyca requested a review from galvana May 9, 2024 18:43
@MarcGEthyca MarcGEthyca self-assigned this May 10, 2024
@MarcGEthyca MarcGEthyca merged commit 0f81185 into main May 10, 2024
40 checks passed
@MarcGEthyca MarcGEthyca deleted the fides_ints_116_review branch May 10, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants