Provide the modal link label function on Fides object #4766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #7033 ↗︎
Details:
Review all test suite changes for PR #4766 ↗︎ |
|||||||||||||||
eastandwestwind
requested changes
Apr 1, 2024
| @@ -40,6 +40,7 @@ existence of Fides *or* subscribe to the global `FidesInitialized` event (see | |||
| - [fides\_string](Fides.md#fides_string) | |||
| - [initialized](Fides.md#initialized) | |||
| - [showModal](Fides.md#showmodal) | |||
| - [getModalLinkLabel](Fides.md#getmodallinklabel) | |||
| @@ -36,6 +48,12 @@ | |||
| <h1>fides.js demo page</h1> | |||
| <p>This page exists to demonstrate the fides.js script.</p> | |||
|
|
|||
| <div> | |||
| <button type="button" onclick="deleteCookie()"> | |||
| delete cookie and reload | |||
There was a problem hiding this comment.
thanks for adding this here too!
eastandwestwind
approved these changes
Apr 2, 2024
| @@ -45,6 +47,37 @@ describe("i18n-utils", () => { | |||
| { locale: "en", label_en: "English", label_original: "English" }, | |||
| { locale: "es", label_en: "Spanish", label_original: "Español" }, | |||
| ]; | |||
| const mockI18nCatalogLoad = [ | |||
There was a problem hiding this comment.
thanks for extracting these out 💯
| @@ -906,6 +865,42 @@ describe("i18n-utils", () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe("localizeModalLinkText", () => { | |||
There was a problem hiding this comment.
super easy to read, nice work!
gilluminate
deleted the
PROD-1710-fides-js-provide-functions-methods-to-get-or-set-the-string-in-a-link
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #PROD-1710
Description Of Changes
Provide the modal link label function to the client based on the current locale unless specified via props to return default locale's language.
Assumes translation string will be returned along with other strings from the server as
modal_link_label(WIP. Not hooked up to BE yet)Code Changes
DEFAULT_MODAL_LINK_LABELwindow.Fidesobject.getModalLinkLabel()instructions.Steps to Confirm
1. Go to
/consent/privacy-experience2. Click US Modal to open its configuration settings
3. Click English (Default) language
4. Add some English text in the "Trigger link label" field and Save. (eg. "Privacy Options").
5. Click Save again to also save it to the experience.
6. Click US Modal to open its configuration settings again.
7. Open the Spanish language
8. Add some spanish text in the "Trigger link label" field and Save. (eg. "Opciones de privacidad")
9. Click Save again to also save it to the experience.
?fides_localeset for desired language, and make sure the geolocation used in demo page supports US Modal experience we just configured:*
/fides-js-demo.html?geolocation=us-ut&fides_locale=en*
/fides-js-demo.html?geolocation=us-ut&fides_locale=esFides.getModalLinkLabel()Pre-Merge Checklist
CHANGELOG.md