Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit privacy requests from admin UI #4738

Merged
merged 19 commits into from
Mar 26, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Mar 23, 2024

Closes PROD-1789

Description Of Changes

Adds a form to the privacy request table that allows users to submit privacy requests, using the fields configured for the privacy center.

Screenshot 2024-03-22 at 22 27 01

Code Changes

  • Add new queries to read privacy center config and post a privacy request
  • Regenerate OpenAPI types to accommodate new endpoints

Steps to Confirm

Add the following to .fides/fides.toml, then run Fidesplus backend:

[execution]
require_manual_request_approval = true
allow_custom_privacy_request_field_collection = true
allow_custom_privacy_request_fields_in_request_execution = true
  • Navigate to /privacy-request
  • Click "Submit request"
  • Select a request type from the dropdown
  • Modal should populate with fields from privacy center configuration (by default, this is just email address; email should be required)
  • After typing in an email and checking "I have verified", should be able to submit request then view in the table
  • Make a PUT request to /privacy-center-config with a new config, such as the one in /cypress/fixtures/privacy-requests/privacy-center-config.json
  • Navigate back to /privacy-request
  • Select a request type from the dropdown
  • Modal should populate with fields from new config, including custom fields
  • After filling out required fields and checking "I have verified", should be able to submit request then view in the table

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Mar 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 26, 2024 5:31pm

Copy link

cypress bot commented Mar 23, 2024

Passing run #6867 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 239d4d6 into 6703cb3...
Project: fides Commit: a300893640 ℹ️
Status: Passed Duration: 00:35 💡
Started: Mar 26, 2024 5:44 PM Ended: Mar 26, 2024 5:45 PM

Review all test suite changes for PR #4738 ↗︎

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I just called out some minor misses on the acceptance criteria.

Outside of the code, I reached out to @mfbrown on the Figma designs to potentially change "user" to "subject" for the new modal https://www.figma.com/file/wg7cLWnmVgAOh5POHNhn2K?type=design&node-id=20-33619&mode=design#747437392

@@ -15,7 +15,7 @@ class IdentityInputs(FidesSchema):

class CustomPrivacyRequestField(FidesSchema):
label: str
required: Optional[bool] = False
required: Optional[bool] = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating this to default required to True if not provided to match the current Privacy Center behavior.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (6703cb3) to head (239d4d6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4738   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files         338      338           
  Lines       19993    19993           
  Branches     2555     2555           
=======================================
  Hits        17323    17323           
  Misses       2201     2201           
  Partials      469      469           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! Michael pushed back on my proposal to change "user" to "subject" so you should be all set

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to take back the approval, I just realized we should only show the new button to users that have the PRIVACY_REQUEST_CREATE scope

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, I still see a // TEMP -- do not merge comment in your Cypress tests but I'm not going to hold this up any more, approved!

@jpople jpople merged commit 13f692b into main Mar 26, 2024
48 checks passed
@jpople jpople deleted the jpople/prod-1789/submit-privacy-requests branch March 26, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants