-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide translation interface in notice/experience form when translations aren't enabled #4728
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #6776 ↗︎
Details:
Review all test suite changes for PR #4728 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and thanks for generating the types again 🌟
@@ -24,4 +25,5 @@ export type ExperienceConfigResponse = { | |||
component: ComponentType; | |||
privacy_notices?: Array<PrivacyNoticeResponse>; | |||
translations?: Array<ExperienceTranslationResponse>; | |||
properties?: Array<MinimalProperty>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
@@ -16,6 +16,7 @@ export enum SupportedLanguage { | |||
EL = "el", | |||
EN = "en", | |||
ES = "es", | |||
ES_MX = "es-MX", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this just something we missed before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was some uncertainty with whether we would support Mexican Spanish in addition to Castillian, but I guess that got resolved? Not 100% sure, to be honest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added later, we originally only had "es" (and we saving mexican spanish translations underneath them)! And then we received castillian translations so we switched them and those were saved under es, and we added new "es-mx" for Spanish (Mexico)!
Closes PROD-1820
Description Of Changes
Removes references to translations in the privacy notice and privacy experience forms when user does not have translations enabled on the backend, replacing them with generic "text editing" forms.
Code Changes
Steps to Confirm
Use fidesplus backend on branch
PROD-1819_surface_translation_config_settings
.As a control to confirm translation interfaces still work as expected when translations are enabled, have the following in
.fides/fides.toml
in fidesplus:/consent/privacy-notices
/consent/privacy-experience
Replace
true
withfalse
in the config snippet above, then rerun backend./consent/privacy-notices
/consent/privacy-experience
Pre-Merge Checklist
CHANGELOG.md