-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update privacy notice page to use new table #4641
Update privacy notice page to use new table #4641
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Passing run #6487 ↗︎
Details:
Review all test suite changes for PR #4641 ↗︎ |
…' into PROD-1455-update-privacy-notices-table-to-new-table-component
…-privacy-notices-table-to-new-table-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but just make sure to update the import paths to be absolute ~
wherever you added new imports. I usually reference other places where those components are being imported to verify the paths.
clients/admin-ui/src/features/privacy-notices/PrivacyNoticesTable.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes, approved!
@Kelsey-Ethyca don't forget the change log! |
be55f45
into
PROD-1458_multi_language_support
Closes #PROD-1455
Description Of Changes
Update privacy notice page to use new table component
Before:
After:
Code Changes
PrivacyNoticesTable
to use the new v2 tableSteps to Confirm
consent_multitranslation_plus
from https://github.com/ethyca/fidesplus/pull/1299 withnox -s "build(slim)" "dev(slim)" -- dev
cd client && turbo run dev
The Last Update column, sorting, searching, and filtering will be handled next sprint in https://ethyca.atlassian.net/browse/PROD-1771
Pre-Merge Checklist
CHANGELOG.md