Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update privacy notice page to use new table #4641

Conversation

Kelsey-Ethyca
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca commented Feb 29, 2024

Closes #PROD-1455

Description Of Changes

Update privacy notice page to use new table component

Before:
fides-plus-rc fides-staging ethyca com_consent_privacy-notices (1)
After:
localhost_3000_consent_privacy-notices (2)

Code Changes

  • update PrivacyNoticesTable to use the new v2 table
  • updates to privacy-notice/cells and v2/cells so the new notice table is working with the proper cells
  • update cypress tests to pass

Steps to Confirm

  • run plus branch consent_multitranslation_plus from https://github.com/ethyca/fidesplus/pull/1299 with nox -s "build(slim)" "dev(slim)" -- dev
  • run this branch with cd client && turbo run dev
  • nav to the notices page
  • add systems with data uses
  • toggle notices enabled/disabled
  • click into notices by clicking on the row
  • ensure the columns are correct - Title, Mechanism, Location, Status, Enable
  • ensure you can add and edit privacy notices

The Last Update column, sorting, searching, and filtering will be handled next sprint in https://ethyca.atlassian.net/browse/PROD-1771

Pre-Merge Checklist

Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 5, 2024 1:54am

Copy link

cypress bot commented Feb 29, 2024

Passing run #6487 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 4c78403 into 2448451...
Project: fides Commit: f855932561 ℹ️
Status: Passed Duration: 00:33 💡
Started: Mar 5, 2024 2:04 AM Ended: Mar 5, 2024 2:05 AM

Review all test suite changes for PR #4641 ↗︎

@Kelsey-Ethyca Kelsey-Ethyca changed the base branch from main to PROD-1458_multi_language_support March 2, 2024 05:27
…' into PROD-1455-update-privacy-notices-table-to-new-table-component
…-privacy-notices-table-to-new-table-component
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but just make sure to update the import paths to be absolute ~ wherever you added new imports. I usually reference other places where those components are being imported to verify the paths.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes, approved!

@galvana
Copy link
Contributor

galvana commented Mar 5, 2024

@Kelsey-Ethyca don't forget the change log!

@Kelsey-Ethyca Kelsey-Ethyca merged commit be55f45 into PROD-1458_multi_language_support Mar 5, 2024
10 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the PROD-1455-update-privacy-notices-table-to-new-table-component branch March 5, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants