Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-1697: Bump Debian base image and Python versions to latest (fides) #4630

Merged
merged 10 commits into from
Mar 11, 2024

Conversation

daveqnet
Copy link
Contributor

@daveqnet daveqnet commented Feb 23, 2024

Closes PROD-1697 in ethyca/fides repo

Description Of Changes

  • Bumps Debian base image from -bullseye to -bookworm
  • Bumps supported Python versions
    • 3.10.12 --> 3.10.13
    • 3.9.17 --> 3.9.18
    • 3.8.17 --> 3.8.18

Code Changes

  • Trivial version bumps, see commits.
  • Add home directory for fidesuser so that the git config --global --add safe.directory in the Dockerfile does not fail.
  • Updated Debian package name from python-dev to python-dev-is-python3 (needed in Bookworm)

Steps to Confirm

  • Exec into Docker image and run python --version and cat /etc/os-release e.g.
~ ❯ docker run -it -u 0 --entrypoint /bin/bash ethyca/fides:2.29.0                                                                                                                                                                    х 255 9s
root@e30ec11f98e3:/fides# python --version
Python 3.10.12
root@e30ec11f98e3:/fides# cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 11 (bullseye)"
NAME="Debian GNU/Linux"
VERSION_ID="11"
VERSION="11 (bullseye)"
VERSION_CODENAME=bullseye
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

Pre-Merge Checklist

Copy link

vercel bot commented Feb 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2024 4:00pm

@daveqnet daveqnet marked this pull request as ready for review February 23, 2024 16:22
@daveqnet
Copy link
Contributor Author

I need to resolve the CI failures before this PR can be merged.

@daveqnet daveqnet removed the request for review from RobertKeyser February 23, 2024 18:15
@daveqnet daveqnet marked this pull request as draft February 23, 2024 18:15
Copy link

cypress bot commented Mar 8, 2024

Passing run #6596 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge de88c59 into ef11403...
Project: fides Commit: 7baa36dc8a ℹ️
Status: Passed Duration: 00:34 💡
Started: Mar 11, 2024 4:10 PM Ended: Mar 11, 2024 4:11 PM

Review all test suite changes for PR #4630 ↗︎

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (0863408) to head (de88c59).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4630   +/-   ##
=======================================
  Coverage   86.67%   86.67%           
=======================================
  Files         336      336           
  Lines       20089    20089           
  Branches     2581     2581           
=======================================
  Hits        17413    17413           
  Misses       2203     2203           
  Partials      473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveqnet daveqnet marked this pull request as ready for review March 8, 2024 14:05
@daveqnet daveqnet changed the title PROD-1697: Bump Debian base image and Python versions to latest PROD-1697: Bump Debian base image and Python versions to latest (fides) Mar 8, 2024
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @daveqnet ! Going to miss seeing the bullseye name out there, checks and everything looking good in here as well as locally

@SteveDMurphy SteveDMurphy added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Mar 11, 2024
@daveqnet daveqnet merged commit 5eabf62 into main Mar 11, 2024
45 of 48 checks passed
@daveqnet daveqnet deleted the daveqnet/PROD-1697/python-and-debian-bump branch March 11, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants