Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regulations page #4530

Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Dec 20, 2023

Closes https://ethyca.atlassian.net/browse/PROD-1494

Description Of Changes

https://www.loom.com/share/5a3b8c49537749f59da1ecaa97a16da9?sid=486f6b01-9aea-4eb6-a0f3-16893698f2ed

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 10:35pm

Copy link

cypress bot commented Dec 20, 2023

Passing run #5826 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge a89933e into 1870441...
Project: fides Commit: 08de77912e ℹ️
Status: Passed Duration: 00:35 💡
Started: Jan 2, 2024 10:44 PM Ended: Jan 2, 2024 10:44 PM

Review all test suite changes for PR #4530 ↗︎

@simonkeane33
Copy link

Looking great @allisonking , just a couple of minor enough points :

  1. For the sub group titles, it looks like we're using the same font size and weight as the main "continent" title. The group title should be smaller so that there's some typographic hierarchy from continent to group to locations. So, all that said, can we make sure we're using 18px for the continent title and 16px for the sub group titles, weight should be semibold.
  2. I've added a recommendation for the modal copy into the design if you have a chance to update that.

Otherwise all good. Thank you.

@allisonking
Copy link
Contributor Author

Thanks @simonkeane33 , I've made those changes! They're actually on the branch this one is branched off of, but I've merged it into this branch as well.

image

image

@allisonking allisonking marked this pull request as ready for review January 2, 2024 22:33
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

@allisonking allisonking merged commit 35a02b7 into aking/prod-1493/locations-modal Jan 3, 2024
10 checks passed
@allisonking allisonking deleted the aking/prod-1494/regulation-page branch January 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants