Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Matching Query on None (Salesforce Account Example) #4483

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

SteveDMurphy
Copy link
Contributor

Closes FIDES#274

Description Of Changes

This issue was originally found using the Salesforce connector, where a contact did not have an account. AccountId would return a key and value of None, causing an error in processing.

This change handles the scenario by only appending the param value if exists

Code Changes

  • Add a failing test for the None value scenario
  • Ensure None is no longer appended to the list of params

Steps to Confirm

  • The failing test can be viewed by walking back the change to consolidate_query_matches to require row to exist
  • alternatively, I have staged data in my dev Salesforce that is missing an account for a user and can provide credentials via 1Password

Pre-Merge Checklist

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 3:41pm

@SteveDMurphy SteveDMurphy force-pushed the SteveDMurphy-fides-274-query-matches branch from 7f08d60 to 9a8c708 Compare December 4, 2023 23:39
@SteveDMurphy SteveDMurphy self-assigned this Dec 4, 2023
Copy link

cypress bot commented Dec 4, 2023

Passing run #5547 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8bef025 into 90df50a...
Project: fides Commit: afb55aa69f ℹ️
Status: Passed Duration: 00:34 💡
Started: Dec 7, 2023 3:50 PM Ended: Dec 7, 2023 3:50 PM

Review all test suite changes for PR #4483 ↗︎

@SteveDMurphy SteveDMurphy marked this pull request as ready for review December 4, 2023 23:59
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90df50a) 87.09% compared to head (8bef025) 87.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4483   +/-   ##
=======================================
  Coverage   87.09%   87.09%           
=======================================
  Files         332      332           
  Lines       20507    20508    +1     
  Branches     2641     2642    +1     
=======================================
+ Hits        17860    17861    +1     
  Misses       2180     2180           
  Partials      467      467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice targeted change!

@SteveDMurphy SteveDMurphy merged commit 8a4a72d into main Dec 11, 2023
42 checks passed
@SteveDMurphy SteveDMurphy deleted the SteveDMurphy-fides-274-query-matches branch December 11, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants