-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid Matching Query on None (Salesforce Account Example) #4483
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7f08d60
to
9a8c708
Compare
Passing run #5547 ↗︎
Details:
Review all test suite changes for PR #4483 ↗︎ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4483 +/- ##
=======================================
Coverage 87.09% 87.09%
=======================================
Files 332 332
Lines 20507 20508 +1
Branches 2641 2642 +1
=======================================
+ Hits 17860 17861 +1
Misses 2180 2180
Partials 467 467 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice targeted change!
Closes FIDES#274
Description Of Changes
This issue was originally found using the Salesforce connector, where a contact did not have an account.
AccountId
would return a key and value ofNone
, causing an error in processing.This change handles the scenario by only appending the param value if exists
Code Changes
None
value scenarioNone
is no longer appended to the list of paramsSteps to Confirm
consolidate_query_matches
to requirerow
to existPre-Merge Checklist
CHANGELOG.md