Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GVL vendor id update #4247

Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Oct 10, 2023

Closes #4242

Description Of Changes

Support vendor ids that are prefixed by gvl.

Code Changes

  • Update vendorIsGvl (and rename to vendorGvlEntry since it returns an entry, not a boolean) to look for a prefixed gvl.. This is still backwards compatible so that an id that is just a number will still work too
  • Add a cypress test

Steps to Confirm

  • Everything should still work! This is another one where, without the backend change, it's hard to see what changed, but the cypress tests provide a case of a vendor with id gvl.1 and things still work properly

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Oct 10, 2023

Passing run #4609 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 7509f39 into 26ed7e6...
Project: fides Commit: 97e5a788fe ℹ️
Status: Passed Duration: 01:17 💡
Started: Oct 12, 2023 8:09 PM Ended: Oct 12, 2023 8:10 PM

Review all test suite changes for PR #4247 ↗︎

@allisonking allisonking marked this pull request as ready for review October 10, 2023 20:34
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice backwards-compatible change! This was useful for me to see more Cypress tests examples. I just have one typo fix recommendation but mostly questions for my understanding.

clients/fides-js/src/lib/tcf/vendors.ts Outdated Show resolved Hide resolved
clients/fides-js/src/lib/tcf/vendors.ts Show resolved Hide resolved
clients/fides-js/src/lib/tcf.ts Show resolved Hide resolved
@allisonking allisonking merged commit 1dd694c into aking/prod-1124/ac-string Oct 13, 2023
7 checks passed
@allisonking allisonking deleted the aking/4242/gvl-vendor-id-update branch October 13, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants