Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complex value updates #4200

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Sep 29, 2023

Closes #3899

Description Of Changes

Updating the unflatten_dict util to accept flattened dict values.

Code Changes

  • Updating unflatten_dict util

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@galvana galvana linked an issue Sep 29, 2023 that may be closed by this pull request
@cypress
Copy link

cypress bot commented Sep 29, 2023

Passing run #4448 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge b54ac9e into 7932483...
Project: fides Commit: 3c4f4a0035 ℹ️
Status: Passed Duration: 00:55 💡
Started: Oct 2, 2023 8:26 PM Ended: Oct 2, 2023 8:27 PM

Review all test suite changes for PR #4200 ↗︎

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7932483) 87.67% compared to head (b54ac9e) 87.68%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4200   +/-   ##
=======================================
  Coverage   87.67%   87.68%           
=======================================
  Files         333      333           
  Lines       20743    20748    +5     
  Branches     2690     2691    +1     
=======================================
+ Hits        18187    18192    +5     
  Misses       2093     2093           
  Partials      463      463           
Files Coverage Δ
.../fides/api/service/connectors/saas_query_config.py 93.12% <ø> (ø)
src/fides/api/util/saas_util.py 88.94% <100.00%> (+0.28%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana marked this pull request as ready for review September 29, 2023 22:24
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test!

@Kelsey-Ethyca Kelsey-Ethyca merged commit 455f3be into main Oct 2, 2023
39 checks passed
@Kelsey-Ethyca Kelsey-Ethyca deleted the 3899-fix-complex-value-updates branch October 2, 2023 22:37
Kelsey-Ethyca added a commit that referenced this pull request Oct 2, 2023
@Kelsey-Ethyca Kelsey-Ethyca mentioned this pull request Oct 2, 2023
8 tasks
Kelsey-Ethyca added a commit that referenced this pull request Oct 2, 2023
Kelsey-Ethyca pushed a commit that referenced this pull request Oct 2, 2023
Kelsey-Ethyca added a commit that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SaaS update payload with complex values fails
2 participants