From a92b1ac4b01303886c88da90897713635e732303 Mon Sep 17 00:00:00 2001 From: SteveDMurphy Date: Fri, 29 Sep 2023 16:29:44 +0100 Subject: [PATCH 1/3] feat: modify if to look for key instead of policy Co-authored-by: Neville Samuell --- .../override_implementations/braze_request_overrides.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fides/api/service/saas_request/override_implementations/braze_request_overrides.py b/src/fides/api/service/saas_request/override_implementations/braze_request_overrides.py index 1718d3d331..ee495e2af3 100644 --- a/src/fides/api/service/saas_request/override_implementations/braze_request_overrides.py +++ b/src/fides/api/service/saas_request/override_implementations/braze_request_overrides.py @@ -28,7 +28,7 @@ def braze_user_update( # regardless of the masking strategy in use all_object_fields = row_param_values["all_object_fields"] - if "user.contact.email" in policy.get_erasure_target_categories(): + if "email" in all_object_fields: privacy_request_id = row_param_values[PRIVACY_REQUEST_ID] all_object_fields["email"] = f"{privacy_request_id}@company.com" From d08f76ed86f50fe5b6791170e8ccbfdd29357eae Mon Sep 17 00:00:00 2001 From: SteveDMurphy Date: Mon, 2 Oct 2023 14:52:03 +0100 Subject: [PATCH 2/3] fix: copy same change to if for Domo override --- .../override_implementations/domo_request_overrides.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/fides/api/service/saas_request/override_implementations/domo_request_overrides.py b/src/fides/api/service/saas_request/override_implementations/domo_request_overrides.py index 51063cd115..481bee0443 100644 --- a/src/fides/api/service/saas_request/override_implementations/domo_request_overrides.py +++ b/src/fides/api/service/saas_request/override_implementations/domo_request_overrides.py @@ -31,7 +31,7 @@ def domo_user_update( # regardless of the masking strategy in use all_object_fields = row_param_values["all_object_fields"] - if "user.contact.email" in policy.get_erasure_target_categories(): + if "email" in all_object_fields: privacy_request_id = row_param_values[PRIVACY_REQUEST_ID] all_object_fields["email"] = f"{privacy_request_id}@company.com" all_object_fields["alternateEmail"] = f"{privacy_request_id}@company.com" From a993f4554d3d8770bb2f5ff75471b72e67b132f6 Mon Sep 17 00:00:00 2001 From: SteveDMurphy Date: Mon, 2 Oct 2023 14:52:58 +0100 Subject: [PATCH 3/3] changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c4b83d6d27..3fb17f34f5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -24,6 +24,7 @@ The types of changes are: - TCF overlay can initialize its consent preferences from a cookie [#4124](https://github.com/ethyca/fides/pull/4124) - Various improvements to the TCF modal such as vendor storage disclosures, vendor counts, privacy policies, etc. [#4167](https://github.com/ethyca/fides/pull/4167) - An issue where Braze could not mask an email due to formatting [#4187](https://github.com/ethyca/fides/pull/4187) +- An issue where email was not being overridden correctly for Braze and Domo [#4196](https://github.com/ethyca/fides/pull/4196) ## [2.21.0](https://github.com/ethyca/fides/compare/2.20.2...2.21.0)