Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of vendors with link to vendor tab #4144

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Sep 22, 2023

Closes https://github.com/ethyca/fidesplus/issues/1110

Description Of Changes

Screen.Recording.2023-09-22.at.5.47.11.PM.mov

Code Changes

  • Refactor TcfModalContent which doesn't really need to be its own component anymore. This makes it easier to hoist tab state up one component, which allows us to open the modal with a tab preselected
  • Adds a button which shows the number of vendors, and if you click on it, it will open the modal straight to the vendor tab
  • Removes the "Manage prefereneces" links on stacks which make less sense now that it's in the banner
  • Cypress test

Steps to Confirm

  • Set up a TCF environment
  • When you visit /fides-js-demo.html, you should see the banner pop up with a new button "View our # partners", where # is the number of systems + vendors you have in your data map.
  • Clicking on the button should open the modal, dismiss the banner, and bring you straight to the vendor tab.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Sep 22, 2023

Passing run #4333 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5144b63 into d25a80a...
Project: fides Commit: a8b245cb5c ℹ️
Status: Passed Duration: 01:14 💡
Started: Sep 25, 2023 9:06 PM Ended: Sep 25, 2023 9:07 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review September 25, 2023 15:19
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just 2 nit questions!

clients/fides-js/src/components/tcf/TcfOverlay.tsx Outdated Show resolved Hide resolved
@allisonking allisonking merged commit 57493f6 into main Sep 26, 2023
10 checks passed
@allisonking allisonking deleted the aking/prod-1099/vendor-link branch September 26, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants