Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vendor modal #4107

Merged
merged 17 commits into from
Sep 19, 2023
Merged

Add vendor modal #4107

merged 17 commits into from
Sep 19, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Sep 15, 2023

Closes #4053

Description Of Changes

See loom: https://www.loom.com/share/80d541ca858644b5bd36bd73d76f3f90?sid=00085b20-3fcc-400f-951b-147effe831db

Code Changes

  • Build form for adding a vendor + data use blocks
  • Integrate dictionary suggestions
  • Fixed up some types here and there
  • Expand default inputs to take a textColor
  • Cypress tests

Steps to Confirm

  • Run fidesplus with dictionary enabled
  • Visit the consent management page in admin-ui using turbo dev (it will not show up in production)
  • Try adding vendors and cookies, and watch them show up in the table
  • Click the sparkle icon to get dictionary suggestions
  • If you run fidesplus without the dictionary enabled, you should also still be able to add vendors

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Sep 15, 2023

Passing run #4227 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 5ae1f04 into d5c5293...
Project: fides Commit: 78ec79bb46 ℹ️
Status: Passed Duration: 01:04 💡
Started: Sep 19, 2023 5:02 PM Ended: Sep 19, 2023 5:03 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review September 19, 2023 16:36
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great to me, nice work!

@allisonking allisonking merged commit acf9fc0 into main Sep 19, 2023
10 checks passed
@allisonking allisonking deleted the aking/4053/add-vendor-modal branch September 19, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a modal form for adding a vendor
2 participants