Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCF features and legal basis dropdown #3995

Merged
merged 9 commits into from
Aug 29, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Aug 29, 2023

Closes #3940
Closes #3928

Description Of Changes

  • Renders features and their description (it turns out the code to render features was already in place—just added a description)
  • Adds a legal basis dropdown to both the Purposes tab and the Vendors tab (when purposes are shown)

Features
image

Legal basis dropdown
image

image

image

Code Changes

  • Update typescript types in admin-ui
    • This really doesn't affect fides-js, but it's easier to generate then copy/paste from admin-ui. we've let the admin-ui types get stale
  • Update fides-js types
  • Add descriptions to features
  • Fix bug where systems were not being rendered on purposes anymore (after they got separated from vendors)
  • Add legal basis dropdown
  • Update cypress tests

Steps to Confirm

  • Add some data uses that have legal bases of either "Consent" or "Legitimate interest"
  • Add data uses that have Features which exist in the GVL (for instance, Match and combine offline data sources)
    Example:
    image

Note: make sure your "Features" save!! You need to hit "Enter" after typing it in, since it's actually a multiselect field

  • Visit fides-js-demo.html and see your features and legal basis dropdowns render

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Aug 29, 2023

Passing run #3805 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge a1fa6de into 76b7b26...
Project: fides Commit: b7d0f3e7b5 ℹ️
Status: Passed Duration: 02:06 💡
Started: Aug 29, 2023 9:38 PM Ended: Aug 29, 2023 9:40 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review August 29, 2023 21:27
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @allisonking !

@allisonking allisonking merged commit 46a7132 into aking/3809/tcf-modal Aug 29, 2023
7 checks passed
@allisonking allisonking deleted the aking/3928/tcf-features branch August 29, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants