Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy declaration form fixes #3980

Merged
merged 3 commits into from
Aug 28, 2023
Merged

Privacy declaration form fixes #3980

merged 3 commits into from
Aug 28, 2023

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Aug 25, 2023

Description Of Changes

  • Fixes placeholder value on "features" field to properly indicate that it's not meant to be a true select field
  • Updates "retention period" to be a text input instead of a number field

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Aug 25, 2023

Passing run #3734 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c037f44 into c628efc...
Project: fides Commit: a34dcb274c ℹ️
Status: Passed Duration: 01:07 💡
Started: Aug 25, 2023 7:14 PM Ended: Aug 25, 2023 7:15 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jpople jpople marked this pull request as ready for review August 28, 2023 16:06
@jpople jpople merged commit 9854b0d into main Aug 28, 2023
10 checks passed
@jpople jpople deleted the privacy-declaration-fixes branch August 28, 2023 16:07
jpople added a commit that referenced this pull request Aug 28, 2023
allisonking pushed a commit that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants