Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor GVL filter #3972

Merged
merged 7 commits into from
Aug 25, 2023
Merged

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Aug 23, 2023

Closes #3939

Description Of Changes

Computes whether or not a vendor is part of the GVL. Separately, vendors have been split into vendors and systems on the backend, so this makes sure that they both still render.

Screen.Recording.2023-08-23.at.5.10.40.PM.mov

Code Changes

  • Import gvl.json, which involved a new rollup plugin for using json
  • Adds a function to determine if a vendor is part of the GVL
  • Renders vendors in addition to systems per new backend change
  • Cypress tests

Steps to Confirm

  • nox -s dev to run the backend
  • Run the admin-ui via turbo dev in the admin-ui directory
  • Add a system with a data use i.e. essential.fraud_detection
  • Add another system also with a data use that maps to a purpose/special purpose (can use essential.fraud_detection again). Name it something like "gvl vendor" which would give it a fides_key of gvl_vendor
  • For this system, since we do not expose the vendor_id field, we need to do a little workaround. Visit localhost:8080 and click the authorize button. Authorize with these credentials
  • Do a GET request on /api/v1/system/{fides_key} and fill in gvl_vendor for the fides key
image * Copy the resulting payload into PUT `/api/v1/system` but replace `vendor_id` with `"2"` (or choose your own id from the GVL vendor list) * Now start up the TCF enabled privacy center via `FIDES_PRIVACY_CENTER__TCF_ENABLED=true turbo dev` in `privacy-center` * VPN to an EU region * The TCF modal should come up. Visit the vendor tab * You should see one system marked "GVL" and one not. You should be able to filter as well.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Aug 23, 2023

Passing run #3724 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge c9b0090 into 935ec0d...
Project: fides Commit: 876f7f12a4 ℹ️
Status: Passed Duration: 01:24 💡
Started: Aug 25, 2023 4:18 PM Ended: Aug 25, 2023 4:20 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review August 24, 2023 00:12
@eastandwestwind eastandwestwind merged commit f85ef2a into aking/3809/tcf-modal Aug 25, 2023
7 checks passed
@eastandwestwind eastandwestwind deleted the aking/3939/vendor_is_gvl branch August 25, 2023 21:24
@allisonking allisonking mentioned this pull request Sep 7, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants