Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce verbosity of privacy center logging further #3915

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Aug 11, 2023

Description Of Changes

Small change to suppress the "Bundling generic fides.js & Privacy Center configuration together..." log message in production, as this'll current log every time the fides.js bundle is requested!

Code Changes

  • Only log if process.env.NODE_ENV === "development"

Steps to Confirm

  • n/a

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Aug 11, 2023

Passing run #3534 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 9d5f017 into 3877777...
Project: fides Commit: 1635105c23 ℹ️
Status: Passed Duration: 01:18 💡
Started: Aug 11, 2023 6:58 PM Ended: Aug 11, 2023 7:00 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks!

@NevilleS NevilleS merged commit 385bbec into main Aug 11, 2023
10 checks passed
@NevilleS NevilleS deleted the ns-reduce-pc-logging branch August 11, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants