-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new scenario to refine_target_path #3906
Adding new scenario to refine_target_path #3906
Conversation
Passing run #3511 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3906 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 317 317
Lines 19397 19397
Branches 2494 2494
=======================================
Hits 16938 16938
Misses 2027 2027
Partials 432 432
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah great improvement here - missed edge case, glad it's being addressed!
Closes #3905
Description Of Changes
Updating
refine_target_path
to return an empty path if the path is invalid, meaning the data doesn't exist at the level indicated.Code Changes
refine_target_path
functionSteps to Confirm
test_refine_target_path.py
Pre-Merge Checklist
CHANGELOG.md