Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TS types for privacy notice locations #3787

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jul 14, 2023

Closes #3786

Description Of Changes

Updates the autogenerated typescript type after the location enum change.

image

As a side effect, it looks like some other types got updated which had some effects on the codebase. I did my best to put in reasonable backups, but could definitely use a second set of eyes there.

Code Changes

  • Ran npm run openapi:generate
  • Fixed build errors, hopefully in a reasonable way 🤞
  • Update cypress fixtures

Steps to Confirm

  • Run fidesplus nox -s "build(slim)" -- dev_edge then nox -s "dev(slim")
  • Start up the admin-ui
  • Visit the privacy notice page and click on the EU notice (you'll need a system that has marketing.advertising.first_party.targeted as a data use)
  • Confirm it has all the expected EU locations

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jul 17, 2023

Passing run #3186 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 3f25f7b into 55acc85...
Project: fides Commit: 0bf1f8b9fa ℹ️
Status: Passed Duration: 00:47 💡
Started: Jul 17, 2023 2:28 PM Ended: Jul 17, 2023 2:29 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking marked this pull request as ready for review July 17, 2023 14:10
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@allisonking allisonking merged commit ec70d25 into main Jul 17, 2023
@allisonking allisonking deleted the aking/3786/privacy-notice-locations branch July 17, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot configure Privacy Notice locations with updated country codes
2 participants