Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'successfully added custom fields' toast #3779

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 12, 2023

Closes Fidesplus issue 960.

Description Of Changes

Removed the "Custom field successfully saved" toast on saving a resource with custom fields, following conversation with @rsilvery today.

Steps to Confirm

  • submit changes to a system or data use for a system with one or more custom fields
  • "Custom field(s) successfully saved and added to this [resource]" toast should not appear

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jul 12, 2023

Passing run #3149 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 732981f into 12dff1a...
Project: fides Commit: 9f35e170fd ℹ️
Status: Passed Duration: 00:48 💡
Started: Jul 12, 2023 7:20 PM Ended: Jul 12, 2023 7:21 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jpople jpople requested a review from allisonking July 12, 2023 18:42
@jpople jpople merged commit 369c789 into main Jul 13, 2023
@jpople jpople deleted the 960-custom-fields-toast branch July 13, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants