Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds polyfill service to fides-js route #3759

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Jul 10, 2023

Closes #3319

Description Of Changes

Adds polyfill service that automatically includes a fetch polyfill bundle if the detected browser is not compatible with fetch. Using a polyfill service allows us to scale to call other features we wish to include in that bundle, with minimal overhead.

Note that in testing this ticket with browsers that do not support fetch (for example using Chrome 39 and Safari 10), I ran into other issues with the fides-js code that were unrelated to fetch, pertaining to unidentified syntax issues. Since these existed before, I plan to keep this ticket scoped to including fetch when needed, and open up another ticket (#3760) for a fuller-scale evaluation of cross-browser support.

Code Changes

  • Include code to call polyfill service

Steps to Confirm

  • For the scope of this ticket, we only need to ensure that no regressions occur using your default / standard browser. Confirm that navigating to http://localhost:3000/fides-js-demo.html calls the polyfill service, but does not respond with any polyfill code, and all pre-existing functionality with the cookie banner is not broken:
Screenshot 2023-07-10 at 9 20 57 AM

Pre-Merge Checklist

@cypress
Copy link

cypress bot commented Jul 10, 2023

Passing run #3095 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 3ed7d17 into cadbea1...
Project: fides Commit: b31eebb772 ℹ️
Status: Passed Duration: 00:44 💡
Started: Jul 10, 2023 2:09 PM Ended: Jul 10, 2023 2:10 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eastandwestwind eastandwestwind merged commit 1fe9a0e into main Jul 11, 2023
@eastandwestwind eastandwestwind deleted the 3319-fetch-polyfill branch July 11, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fetch polyfill to fides.js for older browsers
2 participants