-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPC indication on fides-js overlay #3673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #2950 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
allisonking
commented
Jun 27, 2023
allisonking
commented
Jun 27, 2023
allisonking
force-pushed
the
aking/fidesplus-958/gpc-overlay
branch
from
June 27, 2023 17:52
1374143
to
47bcdb7
Compare
eastandwestwind
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great @allisonking ! Especially, good catch on that bug 🐛 , just 1 request non-blocking, so I'll go ahead and approve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/ethyca/fidesplus/issues/958
Description Of Changes
Adds GPC indicators to both the modal and the banner
Code Changes
GpcBanner
andGpcBadge
as componentsGpcStatus
type andgetGpcStatusFromNotice
from privacy-center tofides-js
so thatfides-js
can use it tooautomaticallyApplyGPCPreferences
where the cookie consent would be missing keys of notices that were notice only, or already had a preferenceSteps to Confirm
turbo dev
in privacy centerfides-js-components-demo.html
so that the first noticehas_gpc_flag=false
Pre-Merge Checklist
CHANGELOG.md